Henning P. Schmiedehausen wrote:
I don't like this. Yet another C'tor. We shouldn't add C'tors, we should deprecate AbstractFileConfiguration(String) and force people to use the locators directly. What is wrong with
Configuration conf = new PropertiesConfiguration(new ClassPathLocator().locate(null, "torque.properties"));
There is nothing wrong with this syntax, it's a nice "one liner" to use a custom locator strategy, but people relying on the default strategy shouldn't be forced to use it as they would argue that this syntax looks simpler to them :
Configuration conf = new PropertiesConfiguration("torque.properties");I hate adding "convenience constructors". They always come back to haunt you.
It's... well... convenient though ;) I will not push for a (String, Locator) constructor, I can live without it, but I'm not favorable to remove the (String) constructor.
Same here. The idea of the locators is to _reduce_ code. Not add new methods.
Well, reducing the code was not my goal, I have no problem with the current size of AbstractFileConfiguration. The goal was just to provide an alternate strategy to locate the configuration files since the current design isn't equivalent to the old ClassPropertiesConfiguration.
Emmanuel Bourg
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
