Emmanuel Bourg wrote:

Oliver Heger wrote:

If this is accepted, we can close the bugs related to XMLConfiguration messing up files on saving (31429, 32240). What do you think?


The last time I pondered if HierarchicalXMLConfiguration could replace XMLConfiguration there was something blocking but I can't remember exactly what, maybe the lack of a save() implementation you fixed earlier, I'll have to check. Do all tests for XMLConfiguration pass with HierarchicalXMLConfiguration ?

Emmanuel Bourg

I think the problem was the handling of comments or in general the fact that the source XML document was not kept. So some stuff could get lost. This should be fixed now.

I have not checked the tests for XMLConfiguration yet. I first wanted to see if there is acceptance for this step at all. If this is the case, I will have a look at the tests.

Oliver

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to