DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=32940>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=32940 ------- Additional Comments From [EMAIL PROTECTED] 2005-01-07 04:50 ------- A couple of additional (minor) comments for you. I'm not sure if the evaluate method is really necessary as a protected method. Whatever dispatch method is called should evaluate to true/false. I don't know that it makes sense to allow subclasses to get too crazy with the return parameter on this. I would also recommend making the method, methodKey and methods properties all private (instead of protected.) The first two are just properties and already have public getters and setters. It also seems risky to allow access to the WeakHashMap to the subclasses. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
