Brent,

Sorry for the latency. I like the API (and "rational number" vs. "fraction" definition), but the numerics (minimizing overflows, speed) could be improved by following the Knuth 4.5.1 algorithms for arithmetic operations and gcd as described in C. Scott Ananian's patch to the old [lang] implementation here:
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29294>, which I applied to the [lang] version.


I will get to this prior to 1.1 if I hear no objections and no one beats me to it.

Phil

Brent Worden wrote:
I just committed a fraction class based on the one found in commons-lang.
Please provide any feedback regarding its correctness, completeness, etc.

Thanks,

Brent Worden


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to