Phil,

thanks for your feedback. Some comments inline.

Phil Steitz wrote:

Looks good to me. I checked the sigs (using http://www.apache.org/dist/jakarta/commons/configuration/KEYS) and hashes and all worked, though the md5 files include trailing cr/lf that caused my script to choke.

Next time I will generate the md5s on Cygwin or linux.


One small nit:

NOTICE.txt is missing from source and binary distros and jar.

Not sure about this. I used maven dist to build the distros. Do I have to tweak the maven.xml so that this file gets included?



Some test cases generate error messages to standard error when I run "ant clean test" though the build succeeds. Don't know if this is a problem or not. It does not look like any test cases actually fail.

I suppose those tests check if exceptions are thrown and then log the message to stderr. It would surely be better to get rid off this output, it might be confusing. But the tests definitely pass.



Phil

Thanks again. Oliver


Oliver Heger wrote:

In preparation for a 1.1 release of commons-configuration I have created the second release candidate.

The files are available for inspection at
http://www.apache.org/~oheger/commons-configuration-1.1rc2

The name of the tag is CONFIGURATION_1_1RC2.

The release notes (in form of the changes report) can be found at
http://jakarta.apache.org/commons/configuration/changes-report.html

Comments are welcome!
Thanks,
Oliver

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to