On Sun, 13 Mar 2005, Kevin A. Burton wrote: > Has annyone had a chance to take a look at the benchmark project I've > been working on? > > http://jakarta.apache.org/commons/sandbox/benchmark/ > > I'm really happy with the way everything is turning out and I'd like to > move from the sandbox to proper so that I can do a release.
I am not an apache committer, so consider these comments appropriately, but I do not feel that benchmark as-is should move to commons proper. A checkstyle report should be generated, as there are lots of style and API problems that I see, public fields, methods with no javadoc, wild-card imports, package-level fields on a public abstract class, etc. Even if the quality of the implementation is good, it doesn't look it at first glance. michael --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
