Hi Jason,
I agree fully - the more tests the better. The tests were mistakenly never added to the 1.3 release (my mistake), and I have since added them to the SVN repository. The net effect of this is that the missing tests have now been added, however they will not be present in an official release until the next stable release (presumably 1.4)
Cheers, Rory
Jason Mathews wrote:
Hi, looks like the NTP impl got added to Net Common package.
However, in the latest build of Net Commons (v1.3) it appears that the contributed NTP + Time jUnit tests got dropped.
I feel the more tests the better esp if those NTP or Time classes get modified in the future.
http://nagoya.apache.org/eyebrowse/[EMAIL PROTECTED]&msgId=1078351
Test classes dropped (which are part of last submitted package):
Directory of C:\net\src\test\org\apache\commons\net\ntp
10/08/2003 09:56 AM 5,876 TimeStampTest.java
Directory of C:\net\src\test\org\apache\commons\net\time
10/08/2003 09:57 AM 6,021 TimeTCPClientTest.java 09/26/2003 08:35 AM 6,332 TimeTestSimpleServer.java
Tried sending this to the <[email protected]> list but for some reason it hasn't been received so I'm trying the direct approach....
--jason
Rory Winston wrote:
Hi Jason,
Your code is in CVS - I had a review, but there was nothing to change, bar
updating the license from Apache 1.0 to 2.0. The code is top quality. Many
thanks for the work, it will be pushed out with the 1.3.0 release (hopefully
not too far away :))
Cheers, Rory
-----Original Message----- From: Jason Mathews [mailto:[EMAIL PROTECTED] Sent: 01 October 2004 16:39 To: Rory Winston Subject: Re: Your NTP submission to Jakarta
Rory Winston wrote:
Hi Jason ( I hope this the correct email address for you),
I am one of the current maintainers of Commons::Net. I have a need for
(S)NTP in my day-to-day, and I have been pointed to your NTP submission
from
last year. I am going to incorporate this into the codebase in the next
couple of days. Thanks for the submission, it looks great. I just wanted to
reassure you that it will actually make it in after all, it looks like it's
been lingering in the TODO list for a long time... :)
Cheers, Rory
Great to hear. I didn't want it to fall in the cracks. A Java implementation of (S)NTP has been greatly needed and at the time none was available.
--j
-- -- Jason Mathews <[EMAIL PROTECTED]> Tel: 781-266-9538 DSN: 845-9538 The MITRE Corporation <http://www.mitre.org/> Bedford, MA 01730-1407
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
