Ok, it sounds like we need to get another patch, or manually separate out the checkstyle from the changes.
Eric, would you mind creating another two patches and attaching them in a post to the list?? Thanks, On 5/11/05, Matt Benson <[EMAIL PROTECTED]> wrote: > I just joined the list myself... (for sandbox > commons-pgp) but I noticed that in the non-checkstyle > changes from this patch, the signature of a public > method is modified in at least one place. This will > break already-compiled code running against the > library. Over in Ant-land we consider that bad; I can > only assume the same would be true in Jakarta commons. > > $0.02, > Matt > > > --- Corey Scott <[EMAIL PROTECTED]> wrote: > > Eric, > > > > Firstly, welcome... Secondly... thanks. > > > > There are two things that would like to suggest with > > your patch. > > > > First: > > Please try to break this patch down into discrete > > sections. i.e. one > > patch for formatting and one for each of the other > > changes. > > > > Second: > > Please submit your patch(es) to the bugzilla as > > files. This allows > > use to keep everything in one place. > > > > Again, welcome and thanks. > > Corey > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: > > [EMAIL PROTECTED] > > For additional commands, e-mail: > > [EMAIL PROTECTED] > > > > > > Discover Yahoo! > Stay in touch with email, IM, photo sharing and more. Check it out! > http://discover.yahoo.com/stayintouch.html > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- http://www.multitask.com.au/people/dion/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
