On Tue, 2005-05-17 at 12:00 +1200, Simon Kitching wrote: > Hi, > > I'm planning to commit a few patches to logging. > > The major patch is to add "internal logging" to LogFactory and > LogFactoryImpl so that when a user sets a system property they can see > what is going on inside JCL. > > java -Dorg.apache.commons.logging.output=/tmp/foo.log MyApp
this is feature that i've wanted to add for some time. i've always thought that 'diagnostics' would be the right name for this. i'd prefer to be able to output to standard error. there are a number of containers that adapter standard error into their logging system and so this would prove useful for diagnostics in those environments. i have no problem supporting an output file in addition. > I'm being careful not to change any *functionality* of JCL as part of > the internal logging patches. However in order to implement the logging > nicely there are a few minor function rearrangements that need to be > done first. I'll commit those as separate patches so people can see > these as there *might* be a functionality change here if I screw up. +1 > Once the internal logging patches are in, I'll propose a few minor > changes to the *functionality* to address the "Log4JLogger does not > implement Log" problem. [Brian: this means agreeing to your proposed > patch to fallback to another logging library if this problem occurs, but > I'll discuss this separately]. i think brian's patch is definitely on the right lines. i've created a branch for containing unit tests developed from the demonstration. i planned to commit something along the lines of brian's patch into that branch. might i suggest we consider either using that branch or a similar one. this should give a good opertunity to review them before deciding what to put into trunk. > I can post the proposed changes as bugzilla entries before committing if > anyone wants - but given the silence to my previous JCL emails I presume > there isn't anyone interested in reviewing them at the moment. i'll review them either before or after they are committed. one of the issues at the moment is that view svn isn't up to date and my mail filters (on this machine) no longer sort the svn messages. it would make things easier for me if i reviewed them before (rather than after) but it's up to you. - robert --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
