I really can't see why it would now cache something that wasn't cached before. Maven isn't using multiple threads, so the cache is essentially a Map. The only change I made ensures that the Tags in the Map are available for GC as soon as the Script that they belong to becomes available. None of that has anything to do with the behavior of the caching... I think.
But, I'm glad to hear that it works. -----Original Message----- From: Brett Porter [mailto:[EMAIL PROTECTED] Sent: Sunday, May 22, 2005 12:39 AM To: Jakarta Commons Developers List Subject: Re: [jelly] SOLVED: Maven issue with Hans memory leak patch -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hans Gilde wrote: >Wait... strike this new patch. My old one should be fine. Now I'm jumping to >conclusions because I haven't looked at it for so long. > >Brett, what's being reused where it wasn't before? I would not expect this >behavior. I believe all it meant was that where before a tag was not cached, now it was - so instead of allocating a new object, it reused it and I was assuming a null value in a variable previously set by the tag. It wasn't a problem to make the change in Maven. As for SVN - I applied your previous patch to jelly. I think everything is fine. - - Brett -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (Cygwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCkAzGOb5RoQhMkRMRAhEVAKCHiNmrBunZvWLVsQrfx8YNF1x1SQCffcHW N2S0RO6DV78ZzM41T8d+yOs= =P5zu -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
