Hello:

Note that RC7 does not change any of the issues in this message thread.
The suggestions below cause one odd problem though: For the enum tests,
an ClassNotFoundException is thrown when trying to load the Enum class
from the custom built class loader. Weird.

Gary

-----Original Message-----
From: Gary Gregory 
Sent: Friday, May 27, 2005 12:08 AM
To: 'Jakarta Commons Developers List'; [EMAIL PROTECTED]
Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

Actually, assuming what is below is acceptable, using Ant 1.6 allows for
a clean up to make the build.xml file shorter with:

    <macrodef name="testit">
        <attribute name="classname"/>
        <sequential>
            <junit printsummary="true" fork="${junit.fork}"
haltonerror="${test.failonerror}">
                <classpath refid="test.classpath"/>
                <test name="@{classname}"/>
            </junit>
        </sequential>
    </macrodef>

    <target name="test.lang" depends="compile.tests">
        <testit classname="org.apache.commons.lang.LangTestSuite"/>
    </target>

    <!-- Ditto for all test targets. -->

Any thoughts on making Ant 1.6 a build pre-req?

Gary

-----Original Message-----
From: Gary Gregory [mailto:[EMAIL PROTECTED] 
Sent: Thursday, May 26, 2005 10:56 PM
To: Jakarta Commons Developers List; [EMAIL PROTECTED]
Subject: RE: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

Hello Steven and All:

Here is a fix for build problems on Sun Java 1.3.1 and 1.2.2.

Instead of using this odd way of invoking unit tests:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <java classname="${test.runner}" fork="${test.fork}"
failonerror="${test.failonerror}">
            <arg value="org.apache.commons.lang.LangTestSuite"/>
            <classpath refid="test.classpath"/>
        </java>
    </target>

I changed this target on my machine to the more standard JUnit
invocation:

    <target name="test.lang" depends="compile.tests">
        <echo message="Running lang package tests ..."/>
        <junit fork="${junit.fork}" haltonerror="${test.failonerror}">
            <classpath refid="test.classpath"/>
            <test name="org.apache.commons.lang.LangTestSuite"/>
        </junit>
    </target>

The test passed on 1.4.2_08, 1.3.1_14 and 1.2.2_017.

Shall I (or Steven) change the JUnit invocation style for all tests?

Gary

-----Original Message-----
From: Simon Kitching [mailto:[EMAIL PROTECTED] 
Sent: Thursday, May 26, 2005 9:07 PM
To: Jakarta Commons Developers List
Subject: Re: FW: [lang] DateUtils test fails under 1.2.2 and not under
1.4.2

On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote:
> That is so very odd. I'm at a loss to explain it. I don't have access
to a 
> system with JDK 1.3 so I'm not able to try it. Maybe someone else can
try?

I've also tried building with JDK1.2.2 on linux.

I got this as part of the output
   [java] Java 1.3 tests not run since the current version is 1.2.2
and also got the DateUtilsTest.testRound failure.

No other problems were encountered.

If Gary is running tests on Windows, then his problem might indicate a
windows-specific issue. Otherwise it looks to me like a system-specific
problem with Gary's setup.

Regards,

Simon




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to