Author: skitching
Date: Tue Jun 7 23:59:50 2005
New Revision: 189540
URL: http://svn.apache.org/viewcvs?rev=189540&view=rev
Log:
Add comments re:
* use of static variable safe in shared classloader
* memory leak possible on webapp undeploy
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java?rev=189540&r1=189539&r2=189540&view=diff
==============================================================================
---
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java
(original)
+++
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java
Tue Jun 7 23:59:50 2005
@@ -317,7 +317,17 @@
// Package private support methods (copied from java.beans.Introspector).
//======================================================================
- // Cache of Class.getDeclaredMethods:
+ // Cache of Class.getDeclaredMethods.
+ //
+ // This static variable is safe even when this code is deployed via a
+ // shared classloader because it is keyed via a Class object. The same
+ // class loaded via two different classloaders will result in different
+ // entries in this map.
+ //
+ // Note, however, that this Hashtable can result in a memory leak. When
+ // this class is in a shared classloader it will retain references to
+ // classes loaded via a webapp classloader even after the webapp has been
+ // undeployed.
private static java.util.Hashtable
declaredMethodCache = new java.util.Hashtable();
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
