On Sat, 2005-06-25 at 21:34 -0700, Phil Steitz wrote: > Before I roll an RC, I need consensus on how we should be doing this. > I see three alternatives, with the PITA level increasing in order: > > 1. Don't worry, be happy - just set maven.compile.target=1.3 and use > maven dist under 1.4 (or 1.5) to generate the jars and roll the > distros. > > 2. Add the following to project.properties > # Fill in path to build JDK or specify this in local build.properties > # When building distribution jars, should use JDK 1.3 > # maven.compile.executable= > maven.compile.fork=true > maven.compile.target=1.3 > maven.jar.manifest=MANIFEST.MF > then specify maven.compile.executable in build.properties and add a > MANIFEST.MF file containing one line: > Build-Jdk: 1.3 > (maven will merge that one line into the manifest that it generates, > making it correct).
Option 2 looks good to me. (I presume you mean setting maven.compile.executable in project.properties). > I am by no means a jdk expert, but from what has been said above, it > looks to me like 1 and 2 both carry some risk (the risk in 2 being due > to lack of classpath control). It would seem, though, that if the > tests all pass when compiled and run under 1.3 against the 1.4 jar, > the risk in even 1. is small (assuming path coverage is good). I don't understand what you mean by "lack of classpath control". I would agree that compiling the core code under 1.4 or 1.5 then compiling and running the tests under 1.3 is sufficient to assure 1.3 compatibility. However I'm not sure that a simple and reliable way of doing that can be found. Option 2 does carry the disadvantages of shipping code compiled with a potentially inferior compiler but I still think it's the best of the available options. The later choices are just too horrible to contemplate. Regards, Simon --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
