[lang][patch] Tests for math sub-package (was RE: [lang] Better coverage for StrBuilder and StrTokenizer.)

[Nathan Beyer]

Here are some additional patches for the 'math' sub-package. The second
attachment is a new test file, since there wasn't a file just for testing
the Range class's base methods.

-----Original Message-----
From: Gary Gregory [mailto:[EMAIL PROTECTED] 
Sent: Saturday, July 30, 2005 6:58 PM
To: Jakarta Commons Developers List
Subject: RE: [lang] Better coverage for StrBuilder and StrTokenizer.

As far as other areas, please look at the clover report [1] or generate
one yourself with Maven and feel free to up the %'s in any deficient
area.

Thanks,
Gary

[1] http://people.apache.org/~ggregory/commons-lang/2.2-dev/docs/clover


Index: src/test/org/apache/commons/lang/math/RandomUtilsTest.java
===================================================================
--- src/test/org/apache/commons/lang/math/RandomUtilsTest.java  (revision 
226698)
+++ src/test/org/apache/commons/lang/math/RandomUtilsTest.java  (working copy)
@@ -46,6 +46,8 @@
     /** test distribution of nextInt() */
     public void testNextInt() {
         tstNextInt(null);
+        
+        assertTrue (RandomUtils.nextInt() >= 0);
     }
     
     /** test distribution of nextInt(Random) */
Index: src/test/org/apache/commons/lang/math/NumberRangeTest.java
===================================================================
--- src/test/org/apache/commons/lang/math/NumberRangeTest.java  (revision 
226698)
+++ src/test/org/apache/commons/lang/math/NumberRangeTest.java  (working copy)
@@ -53,6 +53,44 @@
 
     
//--------------------------------------------------------------------------
 
+    public void testConstructorExceptions() {
+        try {
+            new NumberRange (new Double (Double.NaN));
+            fail("no illegal argument exception");
+        } catch (IllegalArgumentException e) {
+        }
+        
+        try {
+            new NumberRange (new Double (Double.NaN), new Double (12.2));
+            fail("no illegal argument exception");
+        } catch (IllegalArgumentException e) {
+        }
+        
+        try {
+            new NumberRange (new Double (12.2), new Double (Double.NaN));
+            fail("no illegal argument exception");
+        } catch (IllegalArgumentException e) {
+        }
+        
+        try {
+            new NumberRange (new Float (Float.NaN));
+            fail("no illegal argument exception");
+        } catch (IllegalArgumentException e) {
+        }
+        
+        try {
+            new NumberRange (new Float (Float.NaN), new Float(12.2));
+            fail("no illegal argument exception");
+        } catch (IllegalArgumentException e) {
+        }
+        
+        try {
+            new NumberRange (new Float(12.2), new Float (Float.NaN));
+            fail("no illegal argument exception");
+        } catch (IllegalArgumentException e) {
+        }       
+    }
+    
     public void testConstructor1() {
         NumberRange nr = new NumberRange(five);
         assertSame(five, nr.getMinimumNumber());
Index: src/test/org/apache/commons/lang/math/NumberUtilsTest.java
===================================================================
--- src/test/org/apache/commons/lang/math/NumberUtilsTest.java  (revision 
226698)
+++ src/test/org/apache/commons/lang/math/NumberUtilsTest.java  (working copy)
@@ -171,9 +171,12 @@
         assertEquals("createNumber(String) 1 failed", new Float("1234.5"), 
NumberUtils.createNumber("1234.5"));
         assertEquals("createNumber(String) 2 failed", new Integer("12345"), 
NumberUtils.createNumber("12345"));
         assertEquals("createNumber(String) 3 failed", new Double("1234.5"), 
NumberUtils.createNumber("1234.5D"));
+        assertEquals("createNumber(String) 3 failed", new Double("1234.5"), 
NumberUtils.createNumber("1234.5d"));
         assertEquals("createNumber(String) 4 failed", new Float("1234.5"), 
NumberUtils.createNumber("1234.5F"));
+        assertEquals("createNumber(String) 4 failed", new Float("1234.5"), 
NumberUtils.createNumber("1234.5f"));
         assertEquals("createNumber(String) 5 failed", new 
Long(Integer.MAX_VALUE + 1L), NumberUtils.createNumber("" + (Integer.MAX_VALUE 
+ 1L)));
         assertEquals("createNumber(String) 6 failed", new Long(12345), 
NumberUtils.createNumber("12345L"));
+        assertEquals("createNumber(String) 6 failed", new Long(12345), 
NumberUtils.createNumber("12345l"));
         assertEquals("createNumber(String) 7 failed", new Float("-1234.5"), 
NumberUtils.createNumber("-1234.5"));
         assertEquals("createNumber(String) 8 failed", new Integer("-12345"), 
NumberUtils.createNumber("-12345"));
         assertTrue("createNumber(String) 9 failed", 0xFADE == 
NumberUtils.createNumber("0xFADE").intValue());


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]