DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=37344>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=37344 ------- Additional Comments From [EMAIL PROTECTED] 2005-11-03 12:48 ------- Created an attachment (id=16859) --> (http://issues.apache.org/bugzilla/attachment.cgi?id=16859&action=view) HtmlEmail2.java Some notes about my contributed code: I chose not to patch HtmlEmail so that my implementation can co-exist with the original HtmlEmail class; my class is named HtmlEmail2. Secondly I subclassed MultiPartEmail not HtmlEmail since some methods in HtmlEmail were private and in the end my work touched pretty much everything in HtmlEmail. I also raised an issue (bug 37178) with HtmlEmail that if a caller embededs the same image several times into an email then it is encoded several times into the payload of the email. A typical usage scenario for Html emails is that one uses common 'spacer' images. Of course the caller could resolve this for themselves, but as a convenience I chose to implement embed() in a way that identifies common images (using the 'name' parameter) adding them only once into the email. This fix is included in my HtmlEmail2 class. Certain useful methods in the org.apache.commons.mail package have package access restrictions. My code is pacakged in this package so there is no issue, but users of my code will not be able to remove my code into their own package and may get sealing violation issues if they attempt to use it in a separate jar from the binary distribution of commons-email.jar. A simple solution is to obtain the source for commons-email and compile your own jar from source, co-locating my src code with the rest of the formal distribution of the package. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
