DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35882>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35882 ------- Additional Comments From [EMAIL PROTECTED] 2005-11-04 20:53 ------- Is someone else planning on improving the implementation I provided so that it addresses the concerns outlined by Dmitri? I am willing to help if required. Regarding Dmitri's comments: > 1. JXPath does not currently require JDK 1.5. Do we want to introduce that dependency at this point? Removing the dependency on JDK 1.5 from this implementation is trivial. I think it is only the @Override annotation that is 1.5 specific. I have a version of this running in 1.4 so I can provide that if necessary. > 2. The factory does not handle either collections or indexed properties. Handling collections and indexed properties seems kind of complicated. I might need some help to figure out how this could be done. Couldn't the javadoc simply state that collections and indexed properties are not yet supported and we could add such support in a future release? > 3. I believe this factory will sometimes generate NullPointerException. I haven't run into any NPE in practice, but I'm willing add some null guards if you can identify where they are necessary. > 4. I think if we were to bundle an implementation of AbstractFactory with JXPath, it should handle all supported object models, including DOM, JDOM, DynaBeans, maps etc. This is currently beyond my understanding with respect to JXPath and its use of my BeanPropertyFactory. Could you explain how DOM, JDOM, etc. relate to the AbstractFactory? Thanks. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
