On Fri, 2005-11-25 at 22:17 +0000, Niall Pemberton wrote:
> >From my point of view, unless someone objects, both these issues are
> now resolved.
>
> However, having looked in more detail at the code base, I feel that
> the ResourcesBase implementation could do with some improvement in its
> implementation of the content retrieval methods. I have created a
> bugzilla with my proposed changes for review (including JUnit tests)
> here:
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=37642
>
> Comments/feedback would be much appreciated. I'm planning to commit
> these in a few days if there are no objections and then roll a release
> candidate.
I was just checking out the commons-resources source code for a project
I'm working on. Reading the source code I felt the same about the
ResourceBase implementation and after reading your patch I'm definitly
+1 on your changes.
I'm still wondering why the MessageFormat stuff from the Struts
MessageResources wasn't pushed down in commons-resources. I think it
would make sense to have the parametric replacement available in
commons-resources. Does anybody know why it wasn't pushed in when
commons-resources was split out from Struts ?
Greetings,
Christian
> On 11/23/05, Niall Pemberton <[EMAIL PROTECTED]> wrote:
> > I've refreshed the Commons Resources site, sorted most the checkstyle issues
> > and sorted a couple of build issues. AFAIK its pretty much ready for a
> > release. except for a couple of things:
> >
> > 1) Quite a few methods are declaring in the javadoc that they throw
> > RuntimeExceptions, which are coming out on the checkstyle:
> > http://jakarta.apache.org/commons/resources/checkstyle-report.html
> >
> > My preferenc is to removed these, but I can understand why they were put in.
> > Opinions?
> >
> > 2) Rahul raised an issue with JDBCResources on the commons-user list:
> >
> > http://www.mail-archive.com/commons-user%40jakarta.apache.org/msg13618.html
> >
> > Is there anything else needs doing before cutting a release candidate? Would
> > it be useful to provide a more detailled description of the changes I've
> > made?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
--
Christian Meder, email: [EMAIL PROTECTED]
The Way-Seeking Mind of a tenzo is actualized
by rolling up your sleeves.
(Eihei Dogen Zenji)
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
