+1  Looks good.

One nit, which is not worth -0 IMHO, but which you might consider. 
Both bin and src distros unpack to the same directory.  Some people
prefer the src distro to unpack to -src.  This could be accomplished
by adding

<move todir="${maven.dist.src.assembly.dir}-src">
      <fileset dir="${maven.dist.src.assembly.dir}"/>
</move>

to the end of your postGoal on dist:prepare-src-filesystem.

Phil

On 12/10/05, Martin Cooper <[EMAIL PROTECTED]> wrote:
> A new release of Commons FileUpload is long overdue, to say the least, and I
> believe it's ready. The remaining issues are either enhancements or pending
> further input. The distributions for FileUpload 1.1 Release Candidate 1 are
> now available here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/dist/
>
> and the updated web site is here:
>
> http://people.apache.org/~martinc/fileupload/v1.1-rc1/site/
>
> --------------------------------------------------------
> [ ] +1  Release Commons FileUpload 1.1
> [ ] +0  not too fussed, but OK
> [ ] -0  won't block, but think imperfect
> [ ] -1  not until xxx is fixed
> --------------------------------------------------------
>
> Here's my own +1.
>
> --
> Martin Cooper
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to