Another strange things in commits, this time the latest 3 commits to FileHelper:
1. http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/transaction/trunk/ src/java/org/apache/commons/transaction/util/FileHelper.java ?rev=349996&r1=155433&r2=349996&diff_format=h Shouldn't it be if ( ! targetFile.mkdirs()) { -----^----- 2. http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/transaction/trunk/ src/java/org/apache/commons/transaction/util/FileHelper.java ?rev=349997&r1=349996&r2=349997&diff_format=h Fixing the above makes probably this commit obsolete. At least it would no longer be a fix to fix, which only hides the problem in many cases, but might be an optimization. 3. http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/transaction/trunk/ src/java/org/apache/commons/transaction/util/FileHelper.java ?rev=350000&r1=349997&r2=350000&diff_format=h Same like 1., again a missing ! I think. WDYT? Jörg --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
