On Mon, 2006-01-23 at 22:07 +0000, robert burrell donkin wrote: > On Mon, 2006-01-23 at 10:05 +0100, Boris Unckel wrote: > > Hello, > > > > > > robert burrell donkin <[EMAIL PROTECTED]> > > > i've uploaded RC1 to http://people.apache.org/~rdonkin/commons-logging/. > > > please check and test the release candidate and report any mistakes or > > > problems. > > > > > Just to minor things: > > - docs/api is empty, can be removed (docs/apidocs contains javadoc) > > > > - It is comiled with 1.4.2_04 (version from manifest.mf): > > <!-- Version of java class files to generate. --> > > <property name="target.version" value="1.1"/> > > > > <!-- Version of java source to accept --> > > <property name="source.version" value="1.2"/> > > > > The release notes state it could be build for 1.1, but it is not tested. > > Does the JDK1.4 compiler really produce 1.1 code? If not, I would set the > > target.version to 1.2, to avoid errors which do not clearly lead to the > > wrong class version.
Yes I believe the JDK1.4 compiler really does produce 1.1 code when told to. Why wouldn't it? We can't be sure that the resulting jar actually *does* run correctly on java 1.1 because the unit tests require 1.2-or-later features. However there's a good chance that the commons-logging.jar file *does* work on jvm1.1, so it makes sense to compile for that target so that people who care about that have at least an opportunity to try it. > > > > Second 1.4.2_10 is the actual version, for a new release I would prefer the > > latest compiler (even if there a just minor or no changes). JCL releases > > have a long life cycle, and will be widely spread, so it makes sence to > > compile with the latest available version. > > sorry - my bad > > it got very late for me last night and i was too tired to check :( > > when i cut logging releases i do two compile runs (one with 1.2 and one > with a 1.4 JVMs) and then assemble the jars. used the wrong JVM to > assemble them. Why is it necessary to use two different JVMs? Regards, Simon --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
