On 3/4/06, Phil Steitz <[EMAIL PROTECTED]> wrote:
> Found the source of the test failures for me.  I think the code and
> test cases are correct, but somehow the clock precision or something
> else is messing up the chronology for me.  The tests all pass if I
> make spin wait until a full second has elapsed:
>
> private void spin(long now) {
>        while (System.currentTimeMillis() <= now + 1000);  <-- add a sec.
> }
>
> That slows down the tests a bit, but makes them pass.  Has this been
> reported before?

This was modified only recently:

http://svn.apache.org/viewcvs.cgi?rev=369049&view=rev
http://issues.apache.org/bugzilla/show_bug.cgi?id=38130

Maybe theres an issue with the patch I submitted - could you post the
results of the tests without your change to add a sec?

Niall


> Phil
>
> On 3/4/06, Phil Steitz <[EMAIL PROTECTED]> wrote:
> > Works4me on RH FC 2, with both Kb and original method returning kbytes.
> >
> > Looks like there is a cut and paste error in the javadoc for the new
> > method, though.  The "Kb" seems to be missing from the examples.
> >
> > I am also getting test failures for the FileFilterTestCase.  The
> > newfile tests are failing.  I will look at this some more.
> >
> > Phil
> >
> > On 3/4/06, Stephen Colebourne <[EMAIL PROTECTED]> wrote:
> > > If anyone has the ability to test FileSystemUtils.freeSpaceKb() on boxes
> > > other than WindowsXP I'd like to know if the results tally what you'd
> > > expect by calling dir/df directly.
> > >
> > > thanks
> > > Stephen
> > >
> > >
> > > [EMAIL PROTECTED] wrote:
> > > > http://issues.apache.org/bugzilla/show_bug.cgi?id=38574
> > > > ------- Additional Comments From [EMAIL PROTECTED]  2006-03-04 20:16 
> > > > -------
> > > > FileSystemUtils.freeSpaceKb(drive)
> > > > New method that unifies result to be in kilobytes
> > > >
> > > > Please reopen if you believe that the new method returns the wrong 
> > > > result (I can
> > > > on test on Windows)

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to