On 3/13/06, Stephen Colebourne <[EMAIL PROTECTED]> wrote: > All. Please test RC5 or your SVN copy. It should fix the OS X issues, > but obviously I can't actually test that... > > http://people.apache.org/~scolebourne/commons-io/ > <snip/>
Late response as I was traveling, but IMO, the FileSystemUtils test in question is always going to be trouble (though it passes on my machines -- home-brew Linux and XP). Environment variables such as POSIXLY_CORRECT (*nix) or BLOCKSIZE (OS X) can alter the default df output, so df usage without the normalizing -k switch in freeSpace() makes the test fragile. Having said that, I'm largely +1 to the release, and in the process of trying to figure out which thread to vote on ... -Rahul > Stephen > > > Henri Yandell wrote: > > Errors are: > > > > Testcase: > > testThrowsOnNullList(org.apache.commons.io.FileUtilsCleanDirectoryTestCase): > > FAILED > > expected:<0> but was:<1> > > junit.framework.AssertionFailedError: expected:<0> but was:<1> > > at > > org.apache.commons.io.FileUtilsCleanDirectoryTestCase.chmod(FileUtilsCleanDirectoryTestCase.java:161) > > > > Not sure what's going on here. Not sure why we chmod 775 before > > tearing down either :) It's chmodding > > "/Users/hen/apache/jakarta/commons-proper/io/test/io/list-files ", > > which seems to be correct, and chmod'ing a non-existent file returns > > an error code of 1 on both OS X and Debian. > > > > and > > > > > > Testcase: > > testGetFreeSpace_String(org.apache.commons.io.FileSystemUtilsTestCase): > > FAILED > > expected:<9.4452176E7> but was:<4.7226088E7> > > junit.framework.AssertionFailedError: expected:<9.4452176E7> but > > was:<4.7226088E7> > > at > > org.apache.commons.io.FileSystemUtilsTestCase.testGetFreeSpace_String(FileSystemUtilsTestCase.java:68) > > > > The problem here is that OS X uses 512 byte block sizes, not 1k as the > > test assumes. So no way it'll pass. > > > > Hen > > > > On 3/12/06, Henri Yandell <[EMAIL PROTECTED]> wrote: > > > >>On 3/12/06, Stephen Colebourne <[EMAIL PROTECTED]> wrote: > >> > >>>The FileSystemUtils one could be interesting, as so far we've only > >>>really tested on general Unix (gump) and WinXP. No idea why the clean > >>>might fail. > >>> > >>>Can you reproduce this using your SVN copy (in Eclipse)? Otherwise > >>>there's not much I can do. > >> > >>Yep, running maven on the command line I get the same errors. > >> > >>I'll try and dig into it tonight. At least find an hour or so before I > >>dig into the 'need to dos'. > >> > >>Hen > >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
