Author: dion
Date: Sun Mar 19 15:44:00 2006
New Revision: 387069
URL: http://svn.apache.org/viewcvs?rev=387069&view=rev
Log:
Remove extra not - pmd report
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java?rev=387069&r1=387068&r2=387069&view=diff
==============================================================================
---
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java
(original)
+++
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/parser/ASTNENode.java
Sun Mar 19 15:44:00 2006
@@ -60,36 +60,36 @@
else if (left==null || right==null)
{
/*
- * otherwise, both aren't, so it's cleal L != R
+ * otherwise, both aren't, so it's clear L != R
*/
return Boolean.TRUE;
}
else if (left.getClass().equals(right.getClass()))
{
- return (!left.equals(right)) ? Boolean.TRUE : Boolean.FALSE;
+ return (left.equals(right)) ? Boolean.FALSE : Boolean.TRUE;
}
else if(left instanceof Float || left instanceof Double ||
right instanceof Float || right instanceof Double)
{
- return
(!Coercion.coerceDouble(left).equals(Coercion.coerceDouble(right)))
- ? Boolean.TRUE : Boolean.FALSE;
+ return
(Coercion.coerceDouble(left).equals(Coercion.coerceDouble(right)))
+ ? Boolean.FALSE : Boolean.TRUE;
}
else if ( left instanceof Number || right instanceof Number ||
left instanceof Character || right instanceof Character)
{
- return
(!Coercion.coerceLong(left).equals(Coercion.coerceLong(right)))
- ? Boolean.TRUE : Boolean.FALSE;
+ return
(Coercion.coerceLong(left).equals(Coercion.coerceLong(right)))
+ ? Boolean.FALSE : Boolean.TRUE;
}
else if (left instanceof Boolean || right instanceof Boolean)
{
- return
(!Coercion.coerceBoolean(left).equals(Coercion.coerceBoolean(right)))
- ? Boolean.TRUE : Boolean.FALSE;
+ return
(Coercion.coerceBoolean(left).equals(Coercion.coerceBoolean(right)))
+ ? Boolean.FALSE : Boolean.TRUE;
}
else if (left instanceof java.lang.String || right instanceof String)
{
- return (!left.toString().equals(right.toString())) ? Boolean.TRUE
: Boolean.FALSE;
+ return (left.toString().equals(right.toString())) ? Boolean.FALSE
: Boolean.TRUE;
}
- return (!left.equals(right)) ? Boolean.TRUE : Boolean.FALSE;
+ return (left.equals(right)) ? Boolean.FALSE : Boolean.TRUE;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
