-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stephen Colebourne wrote: > I haven't been following this thread closely. However I just took a > quick look at the zip.
Thanks for that. > The ArchiverType/CompressorType interfaces will be a problem. They > indicate that they must be changed when a new type is added to > [compress]. But commons has pretty strict rules about not changing > interfaces. I will change this and use constants instead. Is there a website regarding the mentioned rules? > Personally, I was also unclear as to the reason why there is a split > between archiver and compressor, but then I don't know the low level of > these APIs that well. Archiving and compressing are two different things; while you can add more files to a tar-archive, you can't do that to bzip2/gunzip etc. I didn't want methods in one single interface which work for this format but not sometimes not for other operations. I think it's more easy to recognize that you have to use Archiver for archiving and Compressor for compressing instead to know what the methods do exactly. Cheers + Thanks, Chris > Stephen > > > C. Grobmeier wrote: > Hey all, > > i have just uploaded this: > http://www.grobmeier.de/commons-compress-draft-4.zip > > Tar, Zip and BZip2 is now implemented by the 2 new interfaces. > Please check it out, and tell me, if something more i have to do > before it can be comitted to the compress-code. > > If this looks ok, i will create a bug in bugzilla and add this zip > as attachment. > > Looking forward to read your comments- > Cheers > Chris. >> - --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] >> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFEL5Dzkv8rKBUE/T4RAiYBAJ9ZIck108krrbQihjmqjT9MNyJtigCfef9y s9z0WtbwF7JSarfJ8E1Jt9Q= =XNia -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
