Refactor away! Gary
> -----Original Message----- > From: Henri Yandell [mailto:[EMAIL PROTECTED] > Sent: Tuesday, April 18, 2006 12:29 AM > To: Jakarta Commons Developers List > Subject: [lang] Entities question > > Any ideas why there are unescape(String);String and unescape(Writer, > String) implementations in Entities - independently implemented? They > look like clones of each other - just one has nicer variable names. > > Seems to me that: > > a) One should call the other. > b) One could be deleted (given that Entities isn't public). > > In the latter case, there are two users of the methods: unescapeHtml > calls the Writer,String and unescapeXml calls the String; so we would > delete one and make the two unescapeXxx methods call the same method. > > Same applies for the escape() variants. > > Hen > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
