[ 
http://issues.apache.org/jira/browse/LANG-257?page=comments#action_12412546 ] 

Henri Yandell commented on LANG-257:
------------------------------------

Your patch file is a bit odd, it appears to remove the methods specified rather 
than adding them.

Easiest way to generate the patch is to check out the latest code from 
http://svn.apache.org/repos/asf/jakarta/commons/proper/lang/trunk, modify the 
StringUtils class and run svn diff to get a patch.

Unit tests are also very appreciated as someone will have to write them before 
the code can go in.

> [Patch] - added new methods to StringUtil
> -----------------------------------------
>
>          Key: LANG-257
>          URL: http://issues.apache.org/jira/browse/LANG-257
>      Project: Commons Lang
>         Type: Improvement

>     Versions: 2.1
>     Reporter: Cameron Whitehead
>     Priority: Minor
>  Attachments: StringUtils-enhancements.patch
>
> I added two methods I found helpful.
> public static String[] splitByWholeSeparatorPreserveAllTokens(String str, 
> String separator, int max)
> public static String[] splitByWholeSeparatorPreserveAllTokens(String str, 
> String separator) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to