[ http://issues.apache.org/jira/browse/CHAIN-20?page=comments#action_12413935 ]
Niall Pemberton commented on CHAIN-20: -------------------------------------- I agree with Sean's comment about making method, methodKey and methods properties all private (instead of protected). There are two issues with it - firstly its exposing the Map implementation which from the FastHashMap experience in other components could be a PITA later and secondly it sets the visibility for all descendants which can't then be changed. Far better IMO to provide methods to access the cache rather than expose it this way. I just posted about this on the dev list (chain 1.1 release?) since the checkstyle report highlighted it - should have looked here first :-( > [chain] Provide a "dispatch" command > ------------------------------------ > > Key: CHAIN-20 > URL: http://issues.apache.org/jira/browse/CHAIN-20 > Project: Commons Chain > Type: Improvement > Versions: 1.0 Release > Environment: Operating System: Mac OS X 10.0 > Platform: Macintosh > Reporter: Joe Germuska > Priority: Minor > Attachments: DispatchCommand.java, DispatchCommand.java, > DispatchCommandTestCase.java > > My team and I have developed a preference for the "DispatchAction" style in > Struts to cluster related behavior and decrease the number of classes. While > this is a matter of taste, it seems to be the taste of at least a few people > in > the Struts community. > Is there any interest in providing an abstract base DispatchCommand which > looks > up and invokes an internal method based on either a String property or the > String value of a context value? I started writing such a thing, and will > gladly finish it up, test it, and provide the code for more feedback if > there's > interest. > If people think it's scandalous, we could probably just keep it for internal > use... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
