On 6/6/06, Dennis Lundberg <[EMAIL PROTECTED]> wrote:
Niall Pemberton wrote:
> Release candidate 1 for Chain 1,1 is available for review:
> http://people.apache.org/~niallp/commons-chain/
>
> Release notes for version 1.1 are here:
> http://people.apache.org/~niallp/commons-chain/site/changes-report.html
>
> New version of the chain site:
> http://people.apache.org/~niallp/commons-chain/site/
>
> All feedback on this release candidate build is welcome.
Niall, three things:
Firstly we might have to revert the groupId change in the project.xml
file. I've done some testing and I'm waiting for some guidance from
Brett on how to proceed.
OK, thanks for the heads up - I'll wait to see what happens, but if we
get to a point of wanting to vote on a release before theres an answer
I'll revert it for Chain.
Secondly, I've tried to build the RC from source using Maven and I get a
test failure in TestContextTestCase. The build still succeeds though.
I'm using Sun JDK 1.4.2_11 on Windows XP Pro, if it is of importance.
Here are the details in the test-report:
Hmm weird. I built with JDK 1.4.2_10 on W2K and it passed fine - I
downloaded the latest 1.4 version (JDK 1.4.2_12) and tried it and got
the same result as you.
Anyway appears to be caused by the static property "placeholder"
object its using not being serializable - I've just committed a fix
for this, thanks for spotting it.
I think this warrants a new RC - I'll post RC2 shortly.
Testsuite: org.apache.commons.chain.impl.TestContextTestCase
Tests run: 10, Failures: 0, Errors: 1, Time elapsed: 0,625 sec
Testcase:
testSeriaization(org.apache.commons.chain.impl.TestContextTestCase):
Caused an ERROR
org.apache.commons.chain.impl.ContextBase$1
java.io.NotSerializableException:
org.apache.commons.chain.impl.ContextBase$1
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1054)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:278)
at java.util.HashMap.writeObject(HashMap.java:986)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at
java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:809)
at
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1296)
at
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1247)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1052)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:278)
at
org.apache.commons.chain.impl.ContextBaseTestCase.testSeriaization(ContextBaseTestCase.java:367)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
Finally, I am not getting the same changelog-report as you do. Are you
using a local project.properties file for this? If so, and that is the
way it should be, then a note about it in xdocs/building.xml would be nice.
I use a local build.properties to specify the date of the last release
and a custom version of the changelog plugin which overcomes the
subversion issue wrt to imports to subversion screwing up the index.
I've updated the building.xml with details as you suggested.
Thanks for taking the time to check out the RC - I appreciate the
feedback (especially catching the serialization bug :-).
Niall
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
