[ http://issues.apache.org/jira/browse/SANDBOX-51?page=all ]
Henri Yandell updated SANDBOX-51:
---------------------------------
Component: Exec
> [exec] EnvironmentVariable: inline private constructor
> ------------------------------------------------------
>
> Key: SANDBOX-51
> URL: http://issues.apache.org/jira/browse/SANDBOX-51
> Project: Commons Sandbox
> Type: Bug
> Components: Exec
> Environment: Operating System: other
> Platform: Other
> Reporter: Jerome Lacoste
> Attachments: 36796_environment_variable_inline_constructor.diff
>
> Move the key=value String parsing inside the factory method and remove the
> private constructor.
> There's no need for both and parsing logic is better outside of a constructor
> (as a rule and to make things similar with the rest of the code), especially
> whe
> n there's already a factory.
> Removing the constructor doesn't create an issue as it's private and there's
> already another private one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
