[finder] Make FileFilter implementations public classes in their own package.
-----------------------------------------------------------------------------

                 Key: SANDBOX-159
                 URL: http://issues.apache.org/jira/browse/SANDBOX-159
             Project: Commons Sandbox
          Issue Type: Improvement
          Components: Finder
            Reporter: Niall Pemberton
         Attachments: finder-filters-package.txt

I'm attaching a patch which extracts the FileFilter implementations out of the 
FindingFilter class into a separate "filters" package. This will allow them to 
be re-used in conjunction with a new CompositeFilter.

I've created a new CompositeFilter implementation (which FindingFilter is now 
based on) which can do AND or OR processing which I think will allow quite 
powerful FileFilter implementations to be created - since CompositeFilters 
themselves can be used as component FileFilters for more complex 
CompositeFilters.

For example to select files which are less than 1MB and have been modified in 
the last 20 days

    CompositeFilter filter1 = new CompositeFilter(false, true);
    filter1.addFilter(new SizeFilter(false, "-1m"));
    filter1.addFilter(new TimeFilter(false, 20, false));

As a by-product IMO it will also make creating test cases for the individual 
FileFilter implementations easier.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to