[ http://issues.apache.org/jira/browse/VALIDATOR-188?page=comments#action_12423666 ] Gabriel Belingueres commented on VALIDATOR-188: -----------------------------------------------
Hi, I've seen that this functionality will be included in version 1.4, which will be centered in eliminating the ORO dependency by migrating to Java 1.4. I have two arguments I can think that this may be not the best choice. 1) From the business stand point, we have a window of opportunity that we must take advantage of. I don't personally know how much time it takes to make a new release, but if it is a period such as a month or so for each one, then waiting about two months for a functionality that is already coded doesn't make many sense to me. 2) From a technical stand point, there are many places that will be reluctant to migrate to Java 1.4 for applications that are in production just because of the ISBN thing (though it may be a good excuse anyway) since they are basically just numeric calculations. There are many conservative managers following the philosophy "if it is not broken, don't fix it". Also, the current implementation of ISBN validator uses almost trivial examples of regular expressions, so migrating later to Java 1.4 regexp I don't see it like a big problem (as it could be the email validation code that uses specific Perl semantics in the regexps, then making it more difficult to migrate). Regards, Gabriel > Extend ISBN validator to support smooth transition to ISBN-13 / EAN-13 > standard > ------------------------------------------------------------------------------- > > Key: VALIDATOR-188 > URL: http://issues.apache.org/jira/browse/VALIDATOR-188 > Project: Commons Validator > Issue Type: Improvement > Components: Routines > Affects Versions: 1.2.0 Release > Reporter: Gabriel Belingueres > Fix For: 1.4.0 > > Attachments: ISBNValidator.java, ISBNValidatorTest.java > > > Hi, > I just revised the ISBNValidator to support ISBN-13 / EAN-13 standards, which > will begin its use on 2007 (see > http://www.isbn.org/standards/home/isbn/transition.asp for more information). > To support a smooth transition, I changed the isValid(String) method so that > it can validate all ISBN-10, ISBN-13 and EAN-13 codes. In addition, I created > methods for validating only ISBN-10, only EAN-13, or ISBN-13 / EAN-13 codes. > This way, anyone could have support for > the new standard by just changing the .jar file. > Please note that I've changed a few method names, and you may want to check > the code style to match the existing one (however I tried to follow it > whenever I could). > Regards, > Gabriel Belingueres -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
