[ http://issues.apache.org/jira/browse/SANDBOX-166?page=comments#action_12427099 ] Henri Yandell commented on SANDBOX-166: ---------------------------------------
Looks good to me. I think we'll want to attack the CharBuffer class for bugs a bit as it's at the heart of the system, and it might be valuable for Lang (or there might be something already in there that does the same thing); but the looking at the patch all the changes look good. Do you want to go ahead and do the commits Ortwin? You'll find that I accidentally committed the CsvUtils class before realising that I really should be leaving it for you to do the commit - sorry about that. > Improve memory use > ------------------ > > Key: SANDBOX-166 > URL: http://issues.apache.org/jira/browse/SANDBOX-166 > Project: Commons Sandbox > Issue Type: Improvement > Components: CSV > Affects Versions: Nightly Builds > Reporter: Ortwin Glück > Attachments: optimized.png, patch.txt, profile.png > > > The parser is currently a real memory burner. I fed it a 4MB CSV file and ran > the TPTP profiler. As you can see the parser creates around 100MB of garbage > whereas it could (in really optimized) use around 4MBs. Such figures are not > acceptable within a server environment. Please attach insights and patches to > this issue report. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
