[ http://issues.apache.org/jira/browse/CONFIGURATION-216?page=comments#action_12429798 ] Oliver Heger commented on CONFIGURATION-216: --------------------------------------------
I had a look at your patch. Looks good, and all unit tests are running. One change is problematic however: You removed the methods get/setPath() from AbstractFileConfiguration. This is a binary incompatible change, i.e. it would break existing code. So we can't do this. Is there a special reason why you deleted these methods? I am also a bit concerned regarding semantic compatibility. You had to change the testLocations() test case, which means that the behavior of some of the methods has changed. This could also have an impact on existing code. Wouldn't it be possible to keep the behavior of these methods and only do some additional checks in ConfigurationUtils.locate() ? In any case: Many thanks for your effort! > Inconsistent way to locate filename when creating configuration > --------------------------------------------------------------- > > Key: CONFIGURATION-216 > URL: http://issues.apache.org/jira/browse/CONFIGURATION-216 > Project: Commons Configuration > Issue Type: Bug > Environment: commons-configuration-1.3-dev > Reporter: Gabriele Garuglieri > Assigned To: Oliver Heger > Priority: Minor > Attachments: 216.patch > > > There is a different behaviour locating the configuration file in classpath > depending on the way it is set in the configuration class. > For example assuming "conf/conf1.properties" exists in classpath: > PropertiesConfiguration pc = new > PropertiesConfiguration("conf/conf1.properties"); > gives org.apache.commons.configuration.ConfigurationException: Cannot locate > configuration source conf1.properties > while > PropertiesConfiguration pc = new PropertiesConfiguration(); > pc.setFileName("conf/conf1.properties"); > pc.load(); > properly locate file in classpath and loads it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
