[ http://issues.apache.org/jira/browse/CONFIGURATION-221?page=comments#action_12430097 ] Oliver Heger commented on CONFIGURATION-221: --------------------------------------------
Looks good! The 1.3 release will contain a class called DefaultConfigurationBuilder, which can be used as a substitute of ConfigurationFactory when hierarchical configurations are involved. This class provides support for variable substitution (as other configuration classes do). But for ConfigurationFactory your patch will be a nice enhancement. Is there any chance that you can provide a unit test case for this new feature? (New code is usually only added if corresponding tests exist.) Just ping me if you need help for creating such a test. Many thanks! > Allow system properties in config.xml > ------------------------------------- > > Key: CONFIGURATION-221 > URL: http://issues.apache.org/jira/browse/CONFIGURATION-221 > Project: Commons Configuration > Issue Type: Improvement > Affects Versions: 1.2 Final > Environment: All > Reporter: Rainer Jung > Attachments: commons-configuration_1_2_patch.txt > > > The attached patch allows system properties in the filename attributes of a > config.xml file used in the factory. > The patch is very simple, since commons-digester parses the file and has a > built in capability to do the property substitution. > The dependency of commons-configuration to commons-digester goes up from > version 1.5 to 1.6. The most recent version 1.7 of commons-digester is not > necessary. > The patch can easily be ported to 1.3 and trunk. > Use case: often the config.xml files are contained in a distribution unit > like a war file, that should not be manipulated after packaging. The path > names in config.xml need some way of making them externally variable so that > the packaging unit can be adoped to a special environment without > repackaging. By allowing system properties in the file names, this can be > done easily. > The implementation is simple, short and low risk. > It would be nice, if you considered the patch for inclusion in the next > release. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
