[
http://issues.apache.org/jira/browse/LANG-266?page=comments#action_12436050 ]
Stepan Koltsov commented on LANG-266:
-------------------------------------
Thank you for adding method.
There are typos in the last commit:
Index: src/java/org/apache/commons/lang/StringUtils.java
===================================================================
--- src/java/org/apache/commons/lang/StringUtils.java (revision 448007)
+++ src/java/org/apache/commons/lang/StringUtils.java (working copy)
@@ -2692,7 +2692,7 @@
*
* @param collection the <code>Collection</code> of values to join
together, may be null
* @param separator the separator character to use
- * @return the joined String, <code>null</code> if null iterator input
+ * @return the joined String, <code>null</code> if null collection input
* @since 2.3
*/
public static String join(Collection collection, char separator) {
@@ -2713,7 +2713,7 @@
*
* @param collection the <code>Collection</code> of values to join
together, may be null
* @param separator the separator character to use, null treated as ""
- * @return the joined String, <code>null</code> if null iterator input
+ * @return the joined String, <code>null</code> if null collection input
* @since 2.3
*/
public static String join(Collection collection, String separator) {
> Wish for StringUtils.join(Collection, *)
> ----------------------------------------
>
> Key: LANG-266
> URL: http://issues.apache.org/jira/browse/LANG-266
> Project: Commons Lang
> Issue Type: Wish
> Affects Versions: Nightly Builds
> Reporter: Stepan Koltsov
> Priority: Trivial
> Fix For: 2.3
>
> Attachments: commons-lang-join-collection-stepancheg.diff
>
>
> There is a lack of StringUtils.join(Collection, String) method in
> commons-lang. Could you please add it?
> Commons-lang has method join(Iterator, String), however join(Collection,
> String) is still useful. Join is used very often, and in most situations it
> is used with Collection, not with Iterator, because almost all methods return
> Collections, not Iterators and a lot of data is stored as Collections, not as
> Iterators. The string ".iterator()" has 11 characters while line for code is
> only 72 chars. I've found that in my code there are several methods that
> could be one line shorter if it was StringUtils.join(Collection, String).
> Compare:
> // with StringUtils.join(Collection, String)
> return "UNIQUE (" + StringUtils.join(unique.getColumnNames(), ", ") + ")";
> against:
> // without
> Iterator columnNames = unique.getColumnNames().iterator();
> return "UNIQUE (" + StringUtils.join(columnNames, ", ") + ")";
> Motivation is almost same as "Why we have StringUtils.join(Object[], String)
> while we could write StringUtils.join(Arrays.asList(array).iterator(),
> separator)?"
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
