[ http://issues.apache.org/jira/browse/CONFIGURATION-197?page=comments#action_12438203 ] Oliver Heger commented on CONFIGURATION-197: --------------------------------------------
Had a look at the latest patch. It looks very good. Two points: - For legal reasons all files must contain the typical Apache license header. Can you add this (just copy the header from an existing source file)? - Is it possible for you to provide a unit test for your implementation? All classes must have a unit test before they are added to our code base. Maybe you can use the test case already attached to this ticket as a starting point? If not, I should be able to create a test myself. Thanks! > [configuration] INIConfiguration > -------------------------------- > > Key: CONFIGURATION-197 > URL: http://issues.apache.org/jira/browse/CONFIGURATION-197 > Project: Commons Configuration > Issue Type: Improvement > Affects Versions: 1.0 Alpha > Environment: Operating System: All > Platform: All > Reporter: Matthew Inger > Priority: Minor > Attachments: ini.zip, IniFileConfiguration.java, > IniSectionConfiguration.java, testIniFile.ini, TestIniFileConfiguration.java > > > Currently, configuration does not contain a way to read windows style .ini > files. I am submitting an implementation of Configuration which supplies > this > functionality, along with a test program, and test data -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
