svn commit: r473972 - in /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils: BeanUtilsBean.java locale/LocaleBeanUtilsBean.java

[niallp]

Author: niallp
Date: Sun Nov 12 07:21:35 2006
New Revision: 473972

URL: http://svn.apache.org/viewvc?view=rev&rev=473972
Log:
BEANUTILS-49 - Remove unnecessary synchronization from the static getInstance() 
and setInstance() methods in BeanUtilsBean and LocaleBeanUtilsBean - the 
ContextClassLoaderLocale that they access already has all of its methods 
synchronized. Thanks to Jesper Richter-Reichhelm for reporting this and Kenneth 
Xu for pointing out the unnecessary synchronization.

Modified:
    
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java
    
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java

Modified: 
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java?view=diff&rev=473972&r1=473971&r2=473972
==============================================================================
--- 
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java
 (original)
+++ 
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java
 Sun Nov 12 07:21:35 2006
@@ -75,7 +75,7 @@
      *
      * @return The (pseudo-singleton) BeanUtils bean instance
      */
-    public synchronized static BeanUtilsBean getInstance() {
+    public static BeanUtilsBean getInstance() {
         return (BeanUtilsBean) beansByClassLoader.get();
     }
 
@@ -86,7 +86,7 @@
      * 
      * @param newInstance The (pseudo-singleton) BeanUtils bean instance
      */
-    public synchronized static void setInstance(BeanUtilsBean newInstance) {
+    public static void setInstance(BeanUtilsBean newInstance) {
         beansByClassLoader.set(newInstance);
     }
 

Modified: 
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java?view=diff&rev=473972&r1=473971&r2=473972
==============================================================================
--- 
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
 (original)
+++ 
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
 Sun Nov 12 07:21:35 2006
@@ -57,7 +57,7 @@
                     };
      
      /** Gets singleton instance */
-     public synchronized static LocaleBeanUtilsBean 
getLocaleBeanUtilsInstance() {
+     public static LocaleBeanUtilsBean getLocaleBeanUtilsInstance() {
         return (LocaleBeanUtilsBean)localeBeansByClassLoader.get();
      }
  
@@ -66,7 +66,7 @@
      * This is a pseudo-singleton - an single instance is provided per 
(thread) context classloader.
      * This mechanism provides isolation for web apps deployed in the same 
container. 
      */
-    public synchronized static void setInstance(LocaleBeanUtilsBean 
newInstance) {
+    public static void setInstance(LocaleBeanUtilsBean newInstance) {
         localeBeansByClassLoader.set(newInstance);
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]