[ http://issues.apache.org/jira/browse/CONFIGURATION-238?page=comments#action_12452003 ] Oliver Heger commented on CONFIGURATION-238: --------------------------------------------
This is strange. There is no special handling of comment lines. XMLConfiguration does the following: It parses the XML configuration file using DOM and keeps the resulting DOM tree in memory. Updates of property values also cause this structure to be modified. When the save() method is called, an identity XSLT transformation is used to write the DOM tree back to a file (this will probably cause the ^M characters when the default new line separator 0D 0A is used for Windows). I have no idea why comments are treated differently. But as far as I can tell, this is not under the control of XMLConfiguration, but happens during the XML transformation. > XMLConfiguration.save() - illegal new line char in xml comment > -------------------------------------------------------------- > > Key: CONFIGURATION-238 > URL: http://issues.apache.org/jira/browse/CONFIGURATION-238 > Project: Commons Configuration > Issue Type: Bug > Affects Versions: 1.2 Final > Environment: Windows XP x64 > Reporter: Janusz Studzizba > > I have the following conf.xml. > <?xml version="1.0" encoding="UTF-8"?> > <report-server-config> > <!-- comment > new line in comment --> > <param>value</param> > </report-server-config> > Edited with Vim looks nice. > I use XMLConfiguration to process it. > I perform the following operations: > XMLConfiguration config = new XMLConfiguration("c:\\conf.xml"); > config.save(); > BUG: > After config.save(); my conf.xml file, when edited in Vim, contains > additional ^M char at the end of each line. This is very disturbing. > REASON: > There must be a bug in XMLConfiguration when operating on <!-- --> xml > comments which contain new line characters - as in my example. > <!-- comment > new line in comment --> > My original conf.xml contained 0D 0A chars as a new line in comment, > after calling config.save(); there is ONLY 0A char there! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
