Author: niallp Date: Thu Nov 23 01:23:23 2006 New Revision: 478518 URL: http://svn.apache.org/viewvc?view=rev&rev=478518 Log: VALIDATOR-210 - JavaScript Causes HTML Page to Contain Illegal HTML - thanks to Neil Sherman
Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateByte.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateCreditCard.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateDate.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateEmail.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloat.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloatRange.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateIntRange.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateInteger.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMask.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMaxLength.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMinLength.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateRequired.js jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateShort.js jakarta/commons/proper/validator/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateByte.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateByte.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateByte.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateByte.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields are a valid byte. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateByte(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateCreditCard.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateCreditCard.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateCreditCard.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateCreditCard.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields are a valid creditcard number based on Luhn checksum. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateCreditCard(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateDate.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateDate.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateDate.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateDate.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields are a valid date. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateDate(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateEmail.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateEmail.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateEmail.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateEmail.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields are a valid email address. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateEmail(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloat.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloat.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloat.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloat.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields are a valid float. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateFloat(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloatRange.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloatRange.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloatRange.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateFloatRange.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields are in a valid float range. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateFloatRange(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateIntRange.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateIntRange.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateIntRange.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateIntRange.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields is in a valid integer range. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateIntRange(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateInteger.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateInteger.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateInteger.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateInteger.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields are a valid integer. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateInteger(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMask.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMask.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMask.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMask.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,6 @@ /** * Check to see if fields are a valid using a regular expression. * Fields are not checked if they are disabled. - * <p> * @param form The form validation is taking place on. */ function validateMask(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMaxLength.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMaxLength.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMaxLength.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMaxLength.js Thu Nov 23 01:23:23 2006 @@ -3,10 +3,10 @@ /** * A field is considered valid if less than the specified maximum. * Fields are not checked if they are disabled. - * <p> - * <strong>Caution:</strong> Using <code>validateMaxLength</code> on a password field in a + * + * Caution: Using validateMaxLength() on a password field in a * login page gives unnecessary information away to hackers. While it only slightly - * weakens security, we suggest using it only when modifying a password.</p> + * weakens security, we suggest using it only when modifying a password. * @param form The form validation is taking place on. */ function validateMaxLength(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMinLength.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMinLength.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMinLength.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateMinLength.js Thu Nov 23 01:23:23 2006 @@ -3,10 +3,10 @@ /** * A field is considered valid if greater than the specified minimum. * Fields are not checked if they are disabled. - * <p> - * <strong>Caution:</strong> Using <code>validateMinLength</code> on a password field in a + * + * Caution: Using validateMinLength() on a password field in a * login page gives unnecessary information away to hackers. While it only slightly - * weakens security, we suggest using it only when modifying a password.</p> + * weakens security, we suggest using it only when modifying a password. * @param form The form validation is taking place on. */ function validateMinLength(form) { Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateRequired.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateRequired.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateRequired.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateRequired.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,7 @@ /** * Check to see if fields must contain a value. * Fields are not checked if they are disabled. - * <p> + * * @param form The form validation is taking place on. */ Modified: jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateShort.js URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateShort.js?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateShort.js (original) +++ jakarta/commons/proper/validator/trunk/src/javascript/org/apache/commons/validator/javascript/validateShort.js Thu Nov 23 01:23:23 2006 @@ -3,7 +3,7 @@ /** * Check to see if fields are a valid short. * Fields are not checked if they are disabled. - * <p> + * * @param form The form validation is taking place on. */ function validateShort(form) { Modified: jakarta/commons/proper/validator/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/xdocs/changes.xml?view=diff&rev=478518&r1=478517&r2=478518 ============================================================================== --- jakarta/commons/proper/validator/trunk/xdocs/changes.xml (original) +++ jakarta/commons/proper/validator/trunk/xdocs/changes.xml Thu Nov 23 01:23:23 2006 @@ -40,6 +40,9 @@ <body> <release version="1.3.1" date="Pending"> + <action dev="niallp" type="fix" issue="VALIDATOR-210" due-to="Neil Sherman"> + JavaScript Causes HTML Page to Contain Illegal HTML. + </action> <action dev="niallp" type="update" issue="VALIDATOR-209" due-to="Craig McClanahan"> Additional constructor for ValidatorResources that takes URL[] instead of String[]. </action> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]