Author: olegk
Date: Wed Dec 13 06:05:50 2006
New Revision: 486658
URL: http://svn.apache.org/viewvc?view=rev&rev=486658
Log:
Fix for [HTTPCLIENT-616]: HttpMethodDirector.executeWithRetry method fails to
close the underlying connection if a RuntimeException is thrown
Contributed by Jason Bird
Reviewed by Oleg Kalnichevski
Modified:
jakarta/commons/proper/httpclient/trunk/release_notes.txt
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
Modified: jakarta/commons/proper/httpclient/trunk/release_notes.txt
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/release_notes.txt?view=diff&rev=486658&r1=486657&r2=486658
==============================================================================
--- jakarta/commons/proper/httpclient/trunk/release_notes.txt (original)
+++ jakarta/commons/proper/httpclient/trunk/release_notes.txt Wed Dec 13
06:05:50 2006
@@ -1,5 +1,9 @@
Changes since Release 3.1 Beta 1:
+* [HTTPCLIENT-616] - HttpMethodDirector.executeWithRetry method fixed to close
the
+ underlying connection if a RuntimeException is thrown
+ Contributed by Jason Bird
+
* [HTTPCLIENT-606] - Added a HTTP method level parameter for URI charset
Contributed by Oleg Kalnichevski <olegk at apache.org>
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java?view=diff&rev=486658&r1=486657&r2=486658
==============================================================================
---
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
(original)
+++
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpMethodDirector.java
Wed Dec 13 06:05:50 2006
@@ -453,7 +453,7 @@
releaseConnection = true;
throw e;
} catch (RuntimeException e) {
- if (this.conn.isOpen) {
+ if (this.conn.isOpen()) {
LOG.debug("Closing the connection.");
this.conn.close();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
