[ http://issues.apache.org/jira/browse/VALIDATOR-188?page=all ]
Niall Pemberton resolved VALIDATOR-188.
---------------------------------------
Resolution: Fixed
Assignee: Niall Pemberton
Gabriel,
First of all thanks for raising this issue (I wasn't aware of the ISBN-13
change until you brought it up) and for taking the time to supply patches.
Sorry I didn't answer your points about targeting this for Validator 1.4 - must
have slipped past my radar. Now Java 6 has been released[1] I believe it is
Sun's intention to stop support for JDK 1.3 so IMO I don't believe it will be
such a big issue for most people to have a minimum JDK 1.4 dependency. I have
consulted on moving Validator's minimum JDK dependency[2] and I believe a year
on from the poll I did JDK 1.3 usage will be much lower than the 25% it was
then and will accelerate now JDK 1.3 is "end of life".
ISBNValidator[3] has now been completly re-written with the check digit
calculation factored out into separate routines [4] and (re-)using the new
CodeValidator[5]. Although I didn't directly apply your patches - I did use
your work in the re-write and appreciate you submitting the code in the first
place.
Thanks
Niall
[1] http://www.theserverside.com/news/thread.tss?thread_id=43434
[2] http://tinyurl.com/udvrj
[3]
http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/ISBNValidator.java
[4]
http://jakarta.apache.org/commons/validator/apidocs/org/apache/commons/validator/routines/checkdigit/package-summary.html
[5]
http://svn.apache.org/viewvc/jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/CodeValidator.java
> Extend ISBN validator to support smooth transition to ISBN-13 / EAN-13
> standard
> -------------------------------------------------------------------------------
>
> Key: VALIDATOR-188
> URL: http://issues.apache.org/jira/browse/VALIDATOR-188
> Project: Commons Validator
> Issue Type: Improvement
> Components: Routines
> Affects Versions: 1.2.0 Release
> Reporter: Gabriel Belingueres
> Assigned To: Niall Pemberton
> Fix For: 1.4
>
> Attachments: ISBNValidator.java, ISBNValidatorTest.java
>
>
> Hi,
> I just revised the ISBNValidator to support ISBN-13 / EAN-13 standards, which
> will begin its use on 2007 (see
> http://www.isbn.org/standards/home/isbn/transition.asp for more information).
> To support a smooth transition, I changed the isValid(String) method so that
> it can validate all ISBN-10, ISBN-13 and EAN-13 codes. In addition, I created
> methods for validating only ISBN-10, only EAN-13, or ISBN-13 / EAN-13 codes.
> This way, anyone could have support for
> the new standard by just changing the .jar file.
> Please note that I've changed a few method names, and you may want to check
> the code style to match the existing one (however I tried to follow it
> whenever I could).
> Regards,
> Gabriel Belingueres
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
