[ http://issues.apache.org/jira/browse/LANG-282?page=all ]
Henri Yandell closed LANG-282.
------------------------------
Resolution: Fixed
This has (I think) now been tested to death (last commit on this subject is
r488926, more tests and bugfixes/rewrite).
I'm sure there are still bugs hiding away in here, but it's many leagues ahead
of the version in 2.2.
> Create more tests to test out the +=31 replacement code in
> DurationFormatUtils.
> -------------------------------------------------------------------------------
>
> Key: LANG-282
> URL: http://issues.apache.org/jira/browse/LANG-282
> Project: Commons Lang
> Issue Type: Task
> Reporter: Henri Yandell
> Assigned To: Henri Yandell
> Fix For: 2.3
>
>
> Code being:
> while (days < 0) {
> end.add(Calendar.MONTH, -1);
> days += end.getActualMaximum(Calendar.DAY_OF_MONTH);
> //days += 31; // TODO: Need tests to show this is bad and the new code is
> good.
> // HEN: It's a tricky subject. Jan 15th to March 10th. If I count days-first
> it is
> // 1 month and 26 days, but if I count month-first then it is 1 month and 23
> days.
> // Also it's contextual - if asked for no M in the format then I should
> probably
> // be doing no calculating here.
> months -= 1;
> end.add(Calendar.MONTH, 1);
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
