On 1/8/07, Stephen Colebourne <[EMAIL PROTECTED]> wrote:

-1, here's why...

After reviewing the javadoc, I realised that having an inner class as an
exception is A Bad Idea. It looks wrong in Javadoc, and will look wrong
in code.


Could you say more about this, please? I happen to disagree on exceptions as
inner classes being a bad idea; FileUpload has done this for years, without
any problems. But I'm always interested in hearing new perspectives...

--
Martin Cooper


I propose that this exception is promoted to a top level class, and
renamed to DirectoryWalkCancelledException.

Since we need to build a new RC for Niall's fix, this shouldn't be a big
problem if people agree.

If people disagree with my analysis, then I will of course re-evaluate
this -1 (for which I apologise...)

Stephen



Henri Yandell wrote:
> I've made a first release candidate of IO 1.3, tagged IO_1_3_RC1.
>
> Available at:
>
> http://people.apache.org/~bayard/commons-io/1.3-rc1/
>
> Various build files, clirr/jardiff reports and the proposed site.
>
> [ ] +1
> [ ] -1
>
> Vote to end on Friday (if it makes it that far).
>
> Hen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Reply via email to