Author: tcurdt
Date: Sat Mar 10 03:19:27 2007
New Revision: 516683
URL: http://svn.apache.org/viewvc?view=rev&rev=516683
Log:
better logging
Modified:
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/listeners/ReloadingListener.java
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/stores/ResourceStoreClassLoader.java
jakarta/commons/sandbox/jci/trunk/pom.xml
Modified:
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java?view=diff&rev=516683&r1=516682&r2=516683
==============================================================================
---
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java
(original)
+++
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/ReloadingClassLoader.java
Sat Mar 10 03:19:27 2007
@@ -65,8 +65,7 @@
delegate = new ResourceStoreClassLoader(parent, stores);
return true;
} catch ( final Exception e ) {
- e.printStackTrace();
- // TODO: rethrow?
+ log.error("could not add resource store " + pStore);
}
return false;
}
@@ -83,7 +82,7 @@
//pStore was not found
if ( i == n ) {
- throw new Exception( "pStore was not found" );
+ throw new Exception( "store" + pStore + " was not found" );
}
// if stores length > 1 then array copy old values, else create
new empty store
@@ -101,7 +100,7 @@
return true;
} catch ( final Exception e ) {
- // TODO: re-throw?
+ log.error("could not remove resource store " + pStore, e);
}
return false;
Modified:
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/listeners/ReloadingListener.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/listeners/ReloadingListener.java?view=diff&rev=516683&r1=516682&r2=516683
==============================================================================
---
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/listeners/ReloadingListener.java
(original)
+++
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/listeners/ReloadingListener.java
Sat Mar 10 03:19:27 2007
@@ -139,8 +139,12 @@
}
void notifyReloadNotificationListeners() {
+
for (Iterator it = notificationListeners.iterator(); it.hasNext();) {
final ReloadNotificationListener listener =
(ReloadNotificationListener) it.next();
+
+ log.debug("notifying listener " + listener);
+
listener.handleNotification();
}
}
Modified:
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/stores/ResourceStoreClassLoader.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/stores/ResourceStoreClassLoader.java?view=diff&rev=516683&r1=516682&r2=516683
==============================================================================
---
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/stores/ResourceStoreClassLoader.java
(original)
+++
jakarta/commons/sandbox/jci/trunk/core/src/main/java/org/apache/commons/jci/stores/ResourceStoreClassLoader.java
Sat Mar 10 03:19:27 2007
@@ -42,19 +42,17 @@
final ResourceStore store = stores[i];
final byte[] clazzBytes =
store.read(ClassUtils.convertClassToResourcePath(name));
if (clazzBytes != null) {
- log.debug("found class " + name + " (" +
clazzBytes.length + " bytes)");
+ log.debug(getId() + " found class " + name + " (" +
clazzBytes.length + " bytes)");
return defineClass(name, clazzBytes, 0, clazzBytes.length);
}
}
}
- log.debug("did not find class " + name);
-
return null;
}
protected synchronized Class loadClass(String name, boolean resolve)
throws ClassNotFoundException {
- //log.debug("looking for " + name);
+ log.debug(getId() + " looking for " + name);
Class clazz = findLoadedClass(name);
if (clazz == null) {
@@ -65,13 +63,13 @@
final ClassLoader parent = getParent();
if (parent != null) {
clazz = parent.loadClass(name);
- //log.debug("loaded from parent: " + name);
+ log.debug(getId() + "delegating loading to parent: " +
name);
} else {
throw new ClassNotFoundException(name);
}
} else {
- //log.debug("loaded from store: " + name);
+ log.debug(getId() + " loaded from store: " + name);
}
}
@@ -88,5 +86,9 @@
throw new ClassNotFoundException(name);
}
return clazz;
+ }
+
+ private String getId() {
+ return "" + this + "[" + this.getClass().getClassLoader() + "]";
}
}
Modified: jakarta/commons/sandbox/jci/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/sandbox/jci/trunk/pom.xml?view=diff&rev=516683&r1=516682&r2=516683
==============================================================================
--- jakarta/commons/sandbox/jci/trunk/pom.xml (original)
+++ jakarta/commons/sandbox/jci/trunk/pom.xml Sat Mar 10 03:19:27 2007
@@ -86,6 +86,10 @@
</systemProperties>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>cobertura-maven-plugin</artifactId>
+ </plugin>
</plugins>
<extensions>
<extension>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
