[
https://issues.apache.org/jira/browse/IO-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480566
]
Henri Yandell commented on IO-116:
----------------------------------
Some minor comments (they always occur after you say +1 for some reason):
* Javadoc on FileCleaningTestCase refers to FileCleaner.
* Given that FileCleaner is static, why not implement FileCleaningTestCase
inside FileCleaner?
ie) deprecate the static methods and add non-static methods etc. I know that
BeanUtils didn't do this, so I'm guessing there's some kind of reason for that.
> Replace static FileCleaner methods
> ----------------------------------
>
> Key: IO-116
> URL: https://issues.apache.org/jira/browse/IO-116
> Project: Commons IO
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 1.3.1
> Reporter: Jochen Wiedmann
> Priority: Critical
> Fix For: 1.4
>
> Attachments: commons-io-filecleaningtracker.patch,
> commons-io-filecleaningtracker.patch
>
>
> The attached patch aims to finally resolve the problems, which are named in
> IO-99, FILEUPLOAD-120, and FILEUPLOAD-125.
> I choosed a conservative strategy: Basically I copied the FileCleaner class
> to an instantiable class FileCleaningTracker with instance methods. The
> static FileCleaner methods are now implemented by a static instance of
> FileCleaningTracker. (The name FileCleaningTracker is, of course,
> questionable.
> The FileCleaningTestCase was also created by simply copying FileCleaner to
> FileCleaningTestCase. FileCleanerTestCase is now similarly implemented as a
> subclass of FileCleanerTestCase which uses the static instance of FileCleaner
> rather than a dynamically created instance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
