[
https://issues.apache.org/jira/browse/NET-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rory Winston closed NET-54.
---------------------------
Resolution: Invalid
The code shown is correct. 220 is not a positive preliminary value, rather it
is a positive completion value. Hence isPositivePreliminary() should return
false.
> [net] FTPReply.isPositivePreliminary(int) returns false when reply = 220
> (Server ready) Causes FTPClient.retrieveFile(String, OutputStream) to fail
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: NET-54
> URL: https://issues.apache.org/jira/browse/NET-54
> Project: Commons Net
> Issue Type: Bug
> Affects Versions: 1.4
> Environment: Operating System: other
> Platform: PC
> Reporter: Jeff Barnes
>
> public static boolean isPositivePreliminary(int reply)
> {
> return (reply >= 100 && reply < 200);
> }
> should be changed to
> public static boolean isPositivePreliminary(int reply)
> {
> return (reply >= 100 && reply < 220); //or is it some other magic
> number?
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
