Couple more comments (sorry been digging around in the source code) - the main issue IMO is deprecations
1) Deprecations A number of classes have deprecations - I think these should be removed prior to the first release of JCI: JavaCompilerFactory - static instance (& accessor method) is deprecated FileResourceReader - list() methods deprecated MemoryResourceReader - list() method deprecated FileResourceStore - list() methods deprecated MemoryResourceStore - list() method deprecated 2) ConversionUtils - The toJavaCasing() method is only used by JavaCompilerFactory - perhaps should be a private method in JavaCompilerFactory? - The clazzName() method is not used - should be removed? 3) Commons IO Dependency The Commons IO dependency is only used by 3 classes (ReloadingListener, FileResourceReader and FileResourceStore) and only needs two IOUitls methods - toByteArray() and closeQuietly() (FileResourceReader uses FileUtils but I think it could also use IOUitls.toByteArray() instead). Wouldn't it be better to copy these 2 methods and remove the need for the Commons IO dependency? If this isn't considered a good idea then theres a couple of methods in ConversionUtils that could be replaced by Commons IO: ConversionUtils.stripExtension() --> FilenameUtils.removeExtension() ConversionUtils.getResourceNameFromFileName() --> FilenameUtils.separatorsToUnix() 4) EclipseJavaCompilerSettings The (package friendly) getMap() method of EclipseJavaCompilerSettings overrides/fixes four of the settings in the Map - including setting the source/target version at 1.4 - just wondering why and is this correct? Niall On 4/11/07, Torsten Curdt <[EMAIL PROTECTED]> wrote:
Since RC1 is working fine for cocoon and other parties I would like to call a vote on the release for commons jci. http://jakarta.apache.org/commons/jci/ http://people.apache.org/repo/m2-snapshot-repository/org/apache/ commons/commons-jci/1.0-RC1/ http://people.apache.org/repo/m2-snapshot-repository/org/apache/ commons/commons-jci-core/1.0-RC1/ http://people.apache.org/repo/m2-snapshot-repository/org/apache/ commons/commons-jci-eclipse/1.0-RC1/ http://people.apache.org/repo/m2-snapshot-repository/org/apache/ commons/commons-jci-fam/1.0-RC1/ http://people.apache.org/repo/m2-snapshot-repository/org/apache/ commons/commons-jci-groovy/1.0-RC1/ http://people.apache.org/repo/m2-snapshot-repository/org/apache/ commons/commons-jci-janino/1.0-RC1/ http://people.apache.org/repo/m2-snapshot-repository/org/apache/ commons/commons-jci-javac/1.0-RC1/ http://people.apache.org/repo/m2-snapshot-repository/org/apache/ commons/commons-jci-rhino/1.0-RC1/ Please cast your votes. cheers -- Torsten --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
