[
https://issues.apache.org/jira/browse/CHAIN-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492567
]
kylin commented on CHAIN-37:
----------------------------
OK,but I don't think so,if you just for singleton pattern, then take this
problem , I think use singleton pattern is unseemliness,I believe other users
have same problem.
> The problem of org.apache.commons.chain.impl.ChainBase.execute
> --------------------------------------------------------------
>
> Key: CHAIN-37
> URL: https://issues.apache.org/jira/browse/CHAIN-37
> Project: Commons Chain
> Issue Type: Bug
> Affects Versions: 1.0, 1.1
> Reporter: kylin
> Priority: Critical
>
> The ChainBase.execute metod is not thread safety,I Change the code like that:
> // Execute the commands in this list until one returns true
> // or throws an exception
> boolean saveResult = false;
> Exception saveException = null;
> int i = 0;
> int n = commands.length;
> for (i = 0; i < n; i++) {
> try {
>
> Command command = (Command)commands[i];
>
> Command newCommand =
> ((Command)commands[i].getClass().newInstance());
>
> PropertyUtils.copyProperties(newCommand,command);
>
> saveResult = newCommand.execute(context);
>
> if (saveResult) {
> break;
> }
> } catch (Exception e) {
> saveException = e;
> break;
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
