[
https://issues.apache.org/jira/browse/VFS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495767
]
Adam Heath commented on VFS-148:
--------------------------------
You missed the point. A walker implementation implemented elsewhere needs to
make use of a FileSelectInfo implementation, to pass information to the
FileSelector. With this class being package private, this other implementation
has to make a full implementation of the FileSelectInfo interface.
I'm just trying to reduce code. If the class is made public, this other code
can just instantiate an existing class, instead of having to use a separate
implementation.
However, as I study the code more, what is the real purpose of FileSelectInfo?
Why aren't the properties just passed directly into FileAcceptor? Wouldn't
that make the code simpler to understand(less interfaces to deal with)?
> Make DefaultFileSelectInfo public
> ---------------------------------
>
> Key: VFS-148
> URL: https://issues.apache.org/jira/browse/VFS-148
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Trivial
> Attachments: feature_DefaultFileSelectorInfo_public.patch
>
>
> See $summary, and patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
