[ https://issues.apache.org/jira/browse/CLI-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509037 ]
Henri Yandell commented on CLI-21: ---------------------------------- Here's the clirr error: ERROR: 7009: org.apache.commons.cli.Option: Accessibility of method 'public java.lang.Object clone()' has been decreased from public to protected Solutionwise, I guess we make it public again, drop the exception and throw a RuntimeException if it's thrown. Will attach a patch to that end. I am confused that Clirr doesn't seem to care about the exception being added. > [cli] clone method in Option should use super.clone() > ----------------------------------------------------- > > Key: CLI-21 > URL: https://issues.apache.org/jira/browse/CLI-21 > Project: Commons CLI > Issue Type: Bug > Components: CLI-1.x > Affects Versions: 1.0 > Environment: Operating System: other > Platform: Other > Reporter: Nathan McDonald > Fix For: 1.1 > > Attachments: bug21.patch, CLI-21.patch > > > In > org.apache.commons.cli.Option > public method clone is implemented by creating a new instance through one of > the class Constructors, and then assigning values as required through the > setter methods. > This means that any subclasses of the Option class will not return a true > clone, but a new Option instance instead. > A proper implementation of clone should use super.clone() to create a new > instance, rather than calling the class constructor. This allows shallows > clones to propogate correctly down to subclasses. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]